TYP: sparse.pyi #43514
Merged
TYP: sparse.pyi #43514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzeitlin11
commented
Sep 11, 2021
|
|
||
| index: SparseIndex |
There was a problem hiding this comment.
This could probably be narrowed further in a followup using the relation
kind = "integer" -> returns IntIndex
kind = "block" -> returns BlockIndex
mzeitlin11
added
Sparse
|
LGTM; i think we've gone the white lie route elsewhere but not sure where off the top of my head |
|
thanks @mzeitlin11 |
AlexeyGy
pushed a commit
to AlexeyGy/pandas
that referenced
this pull request
Sep 13, 2021
AlexeyGy
pushed a commit
to AlexeyGy/pandas
that referenced
this pull request
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A start to typing sparse stuff, tried to do this without touching the cython code, hopefully some cleanups possible once typing somewhat specified.
cc @jbrockmendel, one annoying piece going on here is the abstract base class
SparseIndex- it functions entirely like an interface, and so has nothing but abstract methods. Currently, incythononly__init__is defined for the base class, so the current typing with multiple methods in the base class is a bit of a white lie. We could just add all the methods to the base class and have them raiseNotImplementedError, but not sure if that's just unnecessary code bloat since it works as is.