Skip to content

PERF: concat #43354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 2, 2021
Merged

PERF: concat #43354

merged 3 commits into from
Sep 2, 2021

Conversation

jbrockmendel
Copy link
Member

from asv_bench.benchmarks.groupby import *
self = Apply()
self.setup(4)

%timeit self.time_copy_overhead_single_col(4)
213 ms ± 10.9 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)  # <- master
161 ms ± 2.84 ms per loop (mean ± std. dev. of 7 runs, 10 loops each)  # <- PR

@jbrockmendel jbrockmendel added Performance Memory or execution speed performance Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Sep 2, 2021
@jreback jreback added this to the 1.4 milestone Sep 2, 2021
values_flat = values.ravel(order="K")

return isna_all(values_flat)
val = values[0][0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a tad janky, yeah isna_all should do this (ok for now), fix in followon

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yah im hopeful we can get rid of this entirely. if not ill push this down into isna_all

@jreback jreback merged commit 04e720f into pandas-dev:master Sep 2, 2021
@jbrockmendel jbrockmendel deleted the perf-concat branch September 3, 2021 01:15
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Memory or execution speed performance Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants