REF: avoid need for get_join_target in join_non_unique #43217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Refactor
|
can you rebase |
|
rebased + green |
jreback
reviewed
Sep 1, 2021
pandas/core/indexes/base.py
Outdated
| join_array = np.asarray(lvalues.take(left_idx)) | ||
| mask = left_idx == -1 | ||
| np.putmask(join_array, mask, rvalues.take(right_idx)) | ||
| # TODO: just use Index.putmask once GH#43212 is fixed |
There was a problem hiding this comment.
is this changable? as merged the PR around that
There was a problem hiding this comment.
good catch, will update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid a use of get_join_target to move towards allowing arbitrary EA-backed Index