-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
BUG: read_csv with mixed bools and int sometimes reads 1 as a bool function. #43179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @shubham11941140! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-08-23 13:40:10 UTC |
It mentions workflow requires approval, please do the same. I have also got few PEP 8 issues. Do I need to solve them? |
These changes look identical to #42944 with some changes like flipping if statements, test order, and removing comments? |
Ok I will write using reference. |
First, if you build off another PR, you should always reference it (otherwise looks like plagiarism). Also that PR is fine, so there is no reason for another one doing the same thing |
Could you suggest me how do I study with the codebase and then solve bugs? |
The repo is huge due to which I am unable to find and pinpoint issues. |
Closing this to not waste CI resources. Please do not copy code without credit in future. |
https://pandas.pydata.org/docs/development/contributing.html will be helpful. Learning to use a debugger is the best way to learn how to solve bugs (since finding where to fix issues is the hardest part of solving them) |
The major issue is that the parser is reading 1 as a boolean expression and not as an integer.
So, making 2 different tests based on the data type of the input or return of a function can help split the parsing as two seperate entities.
Reference: #42944