REF: Move BaseIndexers and indexer.py functions into their own directory #43065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
changed the title
jreback
requested changes
Aug 17, 2021
pandas/core/indexes/base.py
Outdated
| @@ -144,7 +144,7 @@ | |||
| extract_array, | |||
| sanitize_array, | |||
| ) | |||
| from pandas.core.indexers import deprecate_ndim_indexing | |||
| from pandas.core.indexers.utils import deprecate_ndim_indexing | |||
There was a problem hiding this comment.
can you instead import the needed routines in __init__.py and use an __all__ so the original imports will work e.g. from pandas.core.indexer import .....
jreback
approved these changes
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for unifying some
numbacode between groupby and rolling, movingBaseIndexers to a new directory such thatpandas/core/window.indexers.py->pandas/core/indexers/objects.py(BaseIndexers and their subclasses)pandas/core/indexers.py->pandas/core/indexers/utils.py(misc indexer helper functions)