CLN: let URLError fall through in pandas.io.html._read #4305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
@cpcloud handling network IO is clearly tricky. Were you able to recreate the conditions for the error that was initially raised with the original URL? |
|
nope. just skipping for now if raising |
|
marking for 0.13 because i'm not sure if i'll be able to get this by this weekend |
A skip will now occur if a call to urlopen or a read from the resulting object throws a urllib2.URLError exception
cpcloud
added a commit
that referenced
this pull request
Jul 25, 2013
CLN: let URLError fall through in pandas.io.html._read
|
oh phooey i put in 0.12 release notes 😑 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.