Skip to content

Backport PR #42714 on branch 1.3.x (PERF/REGR: isin slowdown for masked type) #42726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2021
+2 −1
Merged

Backport PR #42714 on branch 1.3.x (PERF/REGR: isin slowdown for masked type) #42726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/whatsnew/v1.3.2.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ including other versions of pandas.

Fixed regressions
~~~~~~~~~~~~~~~~~
- Performance regression in :meth:`DataFrame.isin` and :meth:`Series.isin` for nullable data types (:issue:`42714`)
-
-

Expand Down
2 changes: 1 addition & 1 deletion pandas/core/arrays/masked.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@ def isin(self, values) -> BooleanArray: # type: ignore[override]
# see https://github.com/pandas-dev/pandas/pull/38379 for some discussion
result[self._mask] = values_have_NA

mask = np.zeros_like(self, dtype=bool)
mask = np.zeros(self._data.shape, dtype=bool)
return BooleanArray(result, mask, copy=False)

def copy(self: BaseMaskedArrayT) -> BaseMaskedArrayT:
Expand Down