Skip to content

CLN: move isort config to pyproject.toml #42637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2021

Conversation

fangchenli
Copy link
Member

No description provided.

sections = FUTURE,STDLIB,THIRDPARTY,PRE_LIBS,PRE_CORE,DTYPES,FIRSTPARTY,POST_CORE,LOCALFOLDER
profile = black
combine_as_imports = True
line_length = 88
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line_length = 88 is part of black profile

sections = ["FUTURE", "STDLIB", "THIRDPARTY" ,"PRE_LIBS" , "PRE_CORE", "DTYPES", "FIRSTPARTY", "POST_CORE", "LOCALFOLDER"]
profile = "black"
combine_as_imports = true
force_grid_wrap = 2
Copy link
Member Author

@fangchenli fangchenli Jul 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type of force_grid_wrap is int according to the doc. Setting this to 2 or true has the same effect.

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarcoGorelli MarcoGorelli added the Code Style Code style, linting, code_checks label Jul 21, 2021
@MarcoGorelli MarcoGorelli added this to the 1.4 milestone Jul 21, 2021
@MarcoGorelli MarcoGorelli merged commit 0eceea4 into pandas-dev:master Jul 21, 2021
sthagen added a commit to sthagen/pandas-dev-pandas that referenced this pull request Jul 21, 2021
CLN: move isort config to pyproject.toml (pandas-dev#42637)
@fangchenli fangchenli deleted the move-isort-pyproject branch August 17, 2021 04:16
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
* CLN: move isort config to pyproject.toml

* clean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants