Skip to content

CI: Try to speed up ArrayManager #42634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 25, 2021
Merged

CI: Try to speed up ArrayManager #42634

merged 3 commits into from
Jul 25, 2021

Conversation

lithomas1
Copy link
Member

@lithomas1 lithomas1 commented Jul 20, 2021

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

Don't re-run ArrayManager tests if we are already in ArrayManager mode.

P.S. I'm not sure what the arraymanager marker is supposed to be for. If it only runs the frame tests, wouldn't it be better to just specify that directly in the PYTEST_AM_CMD.

@lithomas1 lithomas1 marked this pull request as ready for review July 21, 2021 01:20
@jbrockmendel
Copy link
Member

did this improve the CI time as intended?

@lithomas1
Copy link
Member Author

Its around 2 min. or ~5% of time.

@jreback jreback added this to the 1.4 milestone Jul 25, 2021
@jreback jreback added ArrayManager CI Continuous Integration labels Jul 25, 2021
@jreback jreback merged commit 7ad5460 into pandas-dev:master Jul 25, 2021
@jreback
Copy link
Contributor

jreback commented Jul 25, 2021

ok this is fine

CGe0516 pushed a commit to CGe0516/pandas that referenced this pull request Jul 29, 2021
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
@lithomas1 lithomas1 deleted the patch-2 branch November 11, 2021 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants