Skip to content

CLN: Remove unused and cleanup imports throughout. #4251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jtratner
Copy link
Contributor

Cleans up imports throughout pandas, removing unused and reordering to
better match PEP8 where reasonable. Thanks to PyCharm for making this much
easier. Doesn't change any .pyx or .pyd files. (inspired by import issue
in #4249)

@jreback
Copy link
Contributor

jreback commented Jul 16, 2013

this is nice....but let's wait till 0.13 (can be first one)...I know prob hard to generate..buts a big change, though needed

@jtratner
Copy link
Contributor Author

@jreback that's fine (and what I expected) - just wanted to remember to do this after the issue that @michaelaye mentioned. Looking forward to 0.13 to merge some of these pending PRs :)

@jreback
Copy link
Contributor

jreback commented Jul 16, 2013

maybe make this on of the first right after 0.13 starts as it touches almost everything....just rebase and speak up after @wesm releases

@jtratner
Copy link
Contributor Author

@jreback maybe it would be better to let other pending PRs happen first (not sure how many there are), so that others don't have to handle rebase conflicts with this relatively trivial-but-useful change? Then after all the pending 0.13 PRs finish up, can redo this with all those changes included.

@jreback
Copy link
Contributor

jreback commented Jul 16, 2013

I don't think there is actually that much pending....its not a big deal really; most of your changes will be fast-forwarded anyhow with little conflict

@jtratner
Copy link
Contributor Author

@jreback got it.

Cleaned up imports throughout pandas, removing unused and reordering to
better match PEP8 where reasonable. Thanks to PyCharm for making this
much easier. Doesn't change any .pyx or .pyd files.
@jtratner
Copy link
Contributor Author

doesn't make sense to do this until we've put in many of the major changes for 0.13. Otherwise just creates headaches for little gain...

@jtratner jtratner deleted the cleanup-imports branch August 1, 2013 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants