ENH: Styler.bar extended to allow centering about the mean, value or callable
#42301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attack68
changed the title
Styler.bar extended to allow centering about the mean, value or callableStyler.bar extended to allow centering about the mean, value or callable
jreback
requested changes
Jul 4, 2021
| @@ -2831,3 +2785,166 @@ def _highlight_between( | |||
| else np.full(data.shape, True, dtype=bool) | |||
| ) | |||
| return np.where(g_left & l_right, props, "") | |||
|
|
|||
|
|
|||
| def _bar( | |||
There was a problem hiding this comment.
could consider moving style* things to a separate dir e.g. pandas/io/formats/style/* and then have flexibility to for example move some utilities to own modules. (obviously for future)
have also done the changes to the doc string and added a |
# Conflicts: # doc/source/whatsnew/v1.4.0.rst
# Conflicts: # doc/source/whatsnew/v1.4.0.rst
jreback
approved these changes
Jul 9, 2021
|
thanks @attack68 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors
Styler.barto allow more flexible arguments to align bars, and an additional keywordpropsakin to other builtin methods that allow some customisation, demonstrated in the new user guide (image below)All previous tests pass with minor formatting alterations.
As a follow-on I should improve the original testing for this function - it is sporadic and unstructured.