Skip to content

BUG: MultiIndex.difference incorrectly raising TypeError when indexes contain non-sortable entries #41915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 17, 2021

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Jun 10, 2021

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

result = idx.difference(other)
tm.assert_index_equal(result, idx)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

behavior change? needs a release note?

@simonjayhawkins simonjayhawkins added Index Related to the Index class or subclasses MultiIndex Refactor Internal refactoring of code labels Jun 10, 2021
@jorisvandenbossche
Copy link
Member

Can you check the performance impact here? (xref #41929 (comment))

@simonjayhawkins simonjayhawkins added Bug and removed Refactor Internal refactoring of code labels Jun 14, 2021
@simonjayhawkins simonjayhawkins changed the title REF: de-duplicate _intersection, _difference BUG: MultiIndex.difference incorrectly raising TypeError when indexes contain non-sortable entries Jun 14, 2021
@jbrockmendel
Copy link
Member Author

Can you check the performance impact here?

ran asvs overnight and no obvious standouts. re-running a subset now to be on the safe side

@jbrockmendel
Copy link
Member Author

yep, all noise

@jreback jreback added this to the 1.3 milestone Jun 17, 2021
@jreback jreback merged commit 9fd7d13 into pandas-dev:master Jun 17, 2021
@jreback
Copy link
Contributor

jreback commented Jun 17, 2021

@meeseeksdev backport 1.3.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jun 17, 2021

Something went wrong ... Please have a look at my logs.

jreback pushed a commit that referenced this pull request Jun 17, 2021
…peError when indexes contain non-sortable entries (#42081)

Co-authored-by: jbrockmendel <jbrockmendel@gmail.com>
@jbrockmendel jbrockmendel deleted the ref-setops-3 branch June 17, 2021 18:53
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Index Related to the Index class or subclasses MultiIndex
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants