REF: do remove DTI._convert_arr_indexer #41803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you rebase |
jreback
added
Index
|
rebased + green |
|
hmm how does this improve things? |
The goal is to get rid of convert_listlike_indexer entirely. After this, its only a MultiIndex thing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: get rid of
_convert_listlike_indexer,_convert_arr_indexer,_convert_list_indexer. These are just convoluted bits of casting before a (inefficient-because-repeated) call toget_indexer.This moves the relevant casting for the DTI/TDI/PI case directly into get_indexer, mirroring how get_loc works for these subclasses.
Upcoming PR does analogous thing for IntervalIndex and CategoricalIndex. MultiIndex is the last one, haven't landed on a solution there.
cc @phofl