TYP: use type annotations in tzconversion.pyi #41771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/_libs/tslibs/tzconversion.pyi
Outdated
| @@ -1,25 +1,21 @@ | |||
| from __future__ import annotations | |||
There was a problem hiding this comment.
maybe not needed for stub file. will need to check.
There was a problem hiding this comment.
don't we need for the | syntax?
There was a problem hiding this comment.
a .pyi is not parsed when running pandas. It is only used by mypy (or other type checkers). The syntax of a .pyi file is not constrained by the minimum python interpreter supported by pandas.
There was a problem hiding this comment.
will need to check.
running pre-commit we don't have any rules that prohibit doing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.