Skip to content

ENH: Improve error message in corr/cov for Rolling/Expanding/EWM when other isn't a DataFrame/Series #41741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 31, 2021

Conversation

mroeschke
Copy link
Member

  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

Also some internal method cleanups

@mroeschke mroeschke added Error Reporting Incorrect or improved errors from pandas Window rolling, ewma, expanding labels May 31, 2021
@mroeschke mroeschke added this to the 1.3 milestone May 31, 2021
@jreback jreback merged commit e8dbdb0 into pandas-dev:master May 31, 2021
@jreback
Copy link
Contributor

jreback commented May 31, 2021

thanks @mroeschke

@mroeschke mroeschke deleted the clean/flex_binary_moment branch May 31, 2021 16:30
TLouf pushed a commit to TLouf/pandas that referenced this pull request Jun 1, 2021
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Error Reporting Incorrect or improved errors from pandas Window rolling, ewma, expanding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants