Min max sparse fillna #41691
Merged
Min max sparse fillna #41691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
taytzehao
commented
May 27, 2021
taytzehao
commented
- closes BUG: self.fill_value ignored in SparseArray.min/max #41552
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
mzeitlin11
reviewed
May 27, 2021
| @@ -1326,6 +1326,8 @@ class TestMinMax: | |||
| data_neg = plain_data * (-1) | |||
| data_NaN = SparseArray(np.array([0, 1, 2, np.nan, 4])) | |||
| data_all_NaN = SparseArray(np.array([np.nan, np.nan, np.nan, np.nan, np.nan])) | |||
| data_NA_filled = SparseArray(np.array([np.nan, np.nan, np.nan, np.nan, np.nan])) | |||
| data_NA_filled.fill_value = 5 | |||
There was a problem hiding this comment.
Can you just pass fill_value in the constructor instead?
doc/source/whatsnew/v1.3.0.rst
Outdated
| @@ -1081,6 +1081,7 @@ Sparse | |||
| - Bug in :meth:`DataFrame.sparse.to_coo` raising ``KeyError`` with columns that are a numeric :class:`Index` without a 0 (:issue:`18414`) | |||
| - Bug in :meth:`SparseArray.astype` with ``copy=False`` producing incorrect results when going from integer dtype to floating dtype (:issue:`34456`) | |||
| - Implemented :meth:`SparseArray.max` and :meth:`SparseArray.min` (:issue:`40921`) | |||
| - Return ``fill_value`` for :meth:`SparseArray.max` and :meth:`SparseArray.min` (:issue:`41552`) | |||
There was a problem hiding this comment.
Think this whatsnew is not needed since min/max was never released with this issue
mzeitlin11
added
Bug
Reduction Operations
|
I am not quite sure what this test failure is pointing towards. It is the same exact failure with my other pull request #41162 |
|
@jbrockmendel , do I need to change any configuration in order for it to pass? Cause I am not sure why is it so |
no, this looks like the CI being flaky for unrelated reasons. you can ignore it |
|
thanks @taytzehao |
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.