Skip to content

TYP: NaTType comparisons #41621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 24, 2021
Merged

TYP: NaTType comparisons #41621

merged 2 commits into from
May 24, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

simonjayhawkins
simonjayhawkins approved these changes May 23, 2021
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jbrockmendel lgtm

@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label May 23, 2021
@simonjayhawkins simonjayhawkins added this to the 1.3 milestone May 23, 2021
@jbrockmendel @simonjayhawkins
Update pandas/_libs/tslibs/nattype.pyi
603a04d 
Co-authored-by: Simon Hawkins <simonjayhawkins@gmail.com>
@simonjayhawkins simonjayhawkins merged commit 4bea042 into pandas-dev:master May 24, 2021
@simonjayhawkins
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the typ-interval-period branch May 24, 2021 15:16
TLouf pushed a commit to TLouf/pandas that referenced this pull request Jun 1, 2021
@jbrockmendel @TLouf
TYP: NaTType comparisons (pandas-dev#41621)
034df31
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@jbrockmendel @JulianWgs
TYP: NaTType comparisons (pandas-dev#41621)
433e585
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @simonjayhawkins