-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
CI: Upgrade "actions/(checkout|cache)" to version 2 #41336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Upgrade "actions/(checkout|cache)" to version 2 #41336
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To get all the tags, you need
- uses: actions/checkout@v2
with:
fetch-depth: 0
@ShaharNaveh do you have time to have a look at the comment and leave the CI green? |
OFC:) |
Checked quickly, and this does seem to speed up the checkout a bit, from around 28 second to around 22 (not sure if very significant, but nice to use the latest version of the action regardless). What I see is that if we don't fetch all tags and branches the checkout is almost immediate (like 2 seconds). I think we need them for the release notes, but I'm not aware of anything else that should require them. @ShaharNaveh would you mind having a look and see if the Also, if you want to have a better look at timings, including the ones of the cache action (I didn't check those), that would be great. |
@datapythonista The way I decided where each
I did see an improvement with the cache, but the difference is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the info @ShaharNaveh. Sounds good. I'd like to understand why we need tags or branches for so many builds, but that's unrelated to this PR.
Thanks for working on this!
Thanks @ShaharNaveh |
We've had several failures in the last couple of days, could there be a compatibility issue with conda-incubator/setup-miniconda@v2 or maybe this was failing before and I didn't notice. |
I saw a connection error on conda, are those the failures you are referring to? We can revert, but probably better to try to understand the problem better first. |
* CI: Upgraded version of "actions/checkout" * CI: Upgraded version of "actions/cache" * Added fetch-depth: 0 Co-authored-by: ShaharNaveh <>
* CI: Upgraded version of "actions/checkout" * CI: Upgraded version of "actions/cache" * Added fetch-depth: 0 Co-authored-by: ShaharNaveh <>
According to the change log of both "checkout" and "cache" this should increase performance.
Fell free to close this PR if this was already discussed, I haven't saw any discussion about this topic.