BUG: retain ordered Categorical dtype in SeriesGroupBy aggregations #41147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
commented
Apr 27, 2021
| result = type(values)._from_sequence(result.ravel(), dtype=values.dtype) | ||
| # Note this will have result.dtype == dtype from above | ||
|
|
||
| elif ( |
There was a problem hiding this comment.
in conjunction with #41086, cast_agg_result becomes a 1-liner and can be cleanly tacked onto the end of py_fallback
jbrockmendel
commented
Apr 27, 2021
rhshadrach
approved these changes
Apr 30, 2021
| ) | ||
| objvals = obj._values | ||
|
|
||
| if isinstance(objvals, Categorical): |
There was a problem hiding this comment.
Does it make sense to try to separate this out further upstream in the future, so that _cython_agg_general isn't calling pure-python methods?
There was a problem hiding this comment.
Ideally we'll get this case handled within WrappedCythonOp._ea_wrap_cython_operation before too long, but im still troubleshooting that
|
@jbrockmendel lgtm. was there a precursor to merge first? |
already got #41111 |
yeshsurya
pushed a commit
to yeshsurya/pandas
that referenced
this pull request
May 6, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATM we correctly wrap them for DataFrameGroupBy but not for SeriesGroupBy. Doing this correctly for SeriesGroupBy has the benefit of avoiding the need to special-case it in DataFrameGroupBy