ERROR: better error message reporting on inserting incompatible column to frame (GH4107) #4108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n to frame (GH4107)
jreback
added a commit
that referenced
this pull request
Jul 3, 2013
ERROR: better error message reporting on inserting incompatible column to frame (GH4107)
|
|
||
| try: | ||
| df['gr'] = df.groupby(['b', 'c']).count() | ||
| except (Exception), detail: |
There was a problem hiding this comment.
@jreback FYI: this format isn't Python 3 compatible, better to use except Exception as detail and frankly you could collapse all of these lines into:
assertRaisesRegexp(TypeError, "incompatible index of inserted column with frame index", df.__setitem__, 'gr', df.groupby(['b', 'c']).count())or
def testit(): df['gr'] = df.groupby(['b', 'c']).count()
assertRaisesRegexp(TypeError, "incompatible index of inserted column with frame index", testit)There was a problem hiding this comment.
I think 2to3 changes in any event
this test (and one above about constructor error msgs) should prob be changed then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4107