CI, STYLE Consolidate pygrep checks #40782
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These checks can be consolidated using multi-line expressions and verbose regex
I think this should make it easier to extend them, so it should be straightforward to port over the remaining ones in code_checks.sh without having to keep increasing the number of hooks
It also reduces the total number of distinct checks (26 now, down from 31 on master), leading to less visual clutter every time we make a commit
The output will still be clear, as it'll just show the line in which an offending pattern was found. E.g. inserting
import conftest
intopandas/tests/io/formats/test_info.py
results in: