Skip to content

DOC: collapse subpages in sidebar for API reference docs #40761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2021

Conversation

jorisvandenbossche
Copy link
Member

The latest version of the theme added the capability to collapse/expand subsections in the sidebar (without directly navigating to the page), see eg the new dropdown arrows on https://pandas.pydata.org/docs/dev/getting_started/index.html

But, an unintended consequence is that the build takesmuch longer (this the reason that the Web / Doc CI build is now always slow on the current open PRs), and this is especially due to our API reference page, which has more than 1000 subpages, and all those pages now have the full navigation structure to all other 1000 pages.

In this PR I am trying to override the base theme template for the sidebar navigation, to not do this for the reference section of our docs.

xref pydata/pydata-sphinx-theme#364

@jbrockmendel
Copy link
Member

cc @datapythonista

@datapythonista
Copy link
Member

Looks like this speeds up to build from 75m to 35m. Having the dropdowns is nice, but I think this makes sense.

@jorisvandenbossche jorisvandenbossche mentioned this pull request Apr 12, 2021
@simonjayhawkins simonjayhawkins added this to the 1.2.5 milestone Apr 12, 2021
@jreback jreback merged commit c80c0c9 into pandas-dev:master Apr 13, 2021
@jreback
Copy link
Contributor

jreback commented Apr 13, 2021

thanks @jorisvandenbossche

@jreback
Copy link
Contributor

jreback commented Apr 13, 2021

@meeseeksdev backport 1.2.x

@lumberbot-app
Copy link

lumberbot-app bot commented Apr 13, 2021

Something went wrong ... Please have a look at my logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants