Skip to content

BUG: fix comparison of NaT with numpy array #40723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jorisvandenbossche
Copy link
Member

Closes #40722

@jorisvandenbossche jorisvandenbossche added Datetime Datetime data dtype Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Regression Functionality that used to work in a prior pandas version Numeric Operations Arithmetic, Comparison, and Logical operations labels Apr 1, 2021
@jorisvandenbossche jorisvandenbossche added this to the 1.2.4 milestone Apr 1, 2021
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jorisvandenbossche
Copy link
Member Author

Verified that the failing builds are matplotlib related

@jorisvandenbossche jorisvandenbossche merged commit 694d058 into pandas-dev:master Apr 1, 2021
@jorisvandenbossche jorisvandenbossche deleted the fix-nat-comparison branch April 1, 2021 18:17
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Apr 1, 2021
vladu pushed a commit to vladu/pandas that referenced this pull request Apr 5, 2021
simonjayhawkins pushed a commit that referenced this pull request Apr 6, 2021
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Datetime Datetime data dtype Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Numeric Operations Arithmetic, Comparison, and Logical operations Regression Functionality that used to work in a prior pandas version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: NaT comparison with numpy array doesn't work element-wise
2 participants