Skip to content

REF: move most of Block.interpolate to an array method #40671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 2, 2021
Merged

REF: move most of Block.interpolate to an array method #40671

merged 7 commits into from
Apr 2, 2021

Conversation

jbrockmendel
Copy link
Member

Not quite at the point where it can be called directly from ArrayManager, but close.

jreback
jreback requested changes Mar 29, 2021
View reviewed changes
pandas/core/missing.py Outdated
@@ -99,6 +103,18 @@ def mask_missing(arr: ArrayLike, values_to_mask) -> np.ndarray:
return mask


def try_clean_fill_method(method):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a bitty smelly, can you just use clean_fill_method?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated + greenish

@jreback jreback added Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code labels Mar 29, 2021
@jbrockmendel
Copy link
Member Author

@jorisvandenbossche have you gotten a chance to look at the Categorical-ArrayManager failure on master?

@jbrockmendel jbrockmendel changed the title REF: move most of Block.interpolate to a array method REF: move most of Block.interpolate to an array method Mar 29, 2021
@jreback jreback added this to the 1.3 milestone Mar 31, 2021
@jreback
Copy link
Contributor

jreback commented Mar 31, 2021

any issues with AM tests @jbrockmendel ?

@jbrockmendel
Copy link
Member Author

any issues with AM tests

nothing showing up in the CI. AM doesnt (yet) call this directly

@jorisvandenbossche
Copy link
Member

Not quite at the point where it can be called directly from ArrayManager, but close.

What's needed additionally to have it usable for ArrayManager?

@jbrockmendel
Copy link
Member Author

What's needed additionally to have it usable for ArrayManager?

the short-circuiting on L1113 and L1123 need some special attention (particularly the one on 1123). Then maybe_downcast at the end needs porting (ive got a branch but am not quite happy with it yet)

@jreback
Copy link
Contributor

jreback commented Apr 2, 2021

can you merge master and ping on green

@jbrockmendel
Copy link
Member Author

ping

@jreback jreback merged commit fe8ca04 into pandas-dev:master Apr 2, 2021
@jbrockmendel jbrockmendel deleted the ref-interp branch April 2, 2021 21:04
vladu pushed a commit to vladu/pandas that referenced this pull request Apr 5, 2021
@jbrockmendel @vladu
REF: move most of Block.interpolate to an array method (pandas-dev#40671
709ecf8 
)
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@jbrockmendel @JulianWgs
REF: move most of Block.interpolate to an array method (pandas-dev#40671
0e4d657 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @jorisvandenbossche