Skip to content

TYP: intp in libalgos #40623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2021
Merged

TYP: intp in libalgos #40623

merged 2 commits into from
Mar 26, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@mzeitlin11
Copy link
Member

@jbrockmendel quick question here so I can be consistent with this as well. What's the rationale behind when we use intp vs int64? Seems like you've mostly been changing arrays responsible for indexing to intp, but not others - are there places we should prefer int64 to intp or would the ultimate goal be to transition to always using intp?

@jbrockmendel
Copy link
Member Author

basically any ndarray we want to use as an indexer, e.g. arr[indexer] or arr.take(indexer) should be intp (because numpy will cast it if it isnt, so we can avoid making a copy)

@jreback jreback added 32bit 32-bit systems Indexing Related to indexing on series/frames, not to indexes themselves Typing type annotations, mypy/pyright type checking labels Mar 26, 2021
@jreback jreback merged commit e40c14d into pandas-dev:master Mar 26, 2021
@jbrockmendel jbrockmendel deleted the cln-intp-libs branch March 26, 2021 15:24
vladu pushed a commit to vladu/pandas that referenced this pull request Apr 5, 2021
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
32bit 32-bit systems Indexing Related to indexing on series/frames, not to indexes themselves Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants