PERF: avoid double-verify of take indices #40391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Mar 12, 2021
jbrockmendel
commented
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
pandas/core/generic.py
Outdated
| @@ -3655,6 +3655,7 @@ class max_speed | |||
|
|
|||
| self._consolidate_inplace() | |||
|
|
|||
| indices = extract_array(indices, extract_numpy=True) | |||
There was a problem hiding this comment.
Why is this needed here? The manager method has an asarray(..) call anyway (to convert other array-likes such as a list, or EAs, etc, so that will also convert any Index or Series passed through)
There was a problem hiding this comment.
leftover from an attempt at stronger annotating. theres at least one test where an Index makes it through to the Block method. will remove.
jorisvandenbossche
approved these changes
Mar 12, 2021
jorisvandenbossche
added
Clean
Internals
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.