Skip to content

BUG: Removed import nose on top of testing.py script #4030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2013
Merged

BUG: Removed import nose on top of testing.py script #4030

merged 1 commit into from
Jun 26, 2013

Conversation

ogiaquino
Copy link
Contributor

I'm having this error in master branch:

import pandas
Traceback (most recent call last):
File "", line 1, in
File "pandas/init.py", line 33, in
from pandas.util.testing import debug
File "pandas/util/testing.py", line 17, in
import nose
ImportError: No module named nose

@jreback
Copy link
Contributor

jreback commented Jun 25, 2013

this is not necessary; how are you building master?

@ogiaquino
Copy link
Contributor Author

I did this:
python setup.py build_ext --inplace

then run:
python setup.py develop

Does pip install pandas will also install nose?

@jreback
Copy link
Contributor

jreback commented Jun 25, 2013

no...you need to install nose separately (and cython too)

@ogiaquino
Copy link
Contributor Author

Okay I might be missing something, but pandas/init.py is importing from pandas.util.testing import debug wouldn't this error out on fresh installs once there's a new release of pandas or nose is part of setup.py requirements?

@jreback
Copy link
Contributor

jreback commented Jun 25, 2013

hmm...i just looked at my installed version and it IS different; apparently this was added recently
so your PR is good! (and we don't test this on travis....nose is automatically installed)

@jreback
Copy link
Contributor

jreback commented Jun 25, 2013

can you hook up travis in any event?

@ogiaquino
Copy link
Contributor Author

Yeah exactly what I thought and perhaps all developers have nose installed already. Okay let me configure travis I don't now why it's not building since I already hook it on my first commit to pandas.

@jreback
Copy link
Contributor

jreback commented Jun 25, 2013

if you can try the build (w/o) nose installed would be good as well....good catch!

jreback added a commit that referenced this pull request Jun 26, 2013
BUG: Removed import nose on top of testing.py script
@jreback jreback merged commit 462b10f into pandas-dev:master Jun 26, 2013
@jreback
Copy link
Contributor

jreback commented Jun 26, 2013

thanks for the catch!

@ogiaquino ogiaquino deleted the Remove_import_nose_in_testing.py branch June 26, 2013 02:19
gdraps referenced this pull request Oct 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants