REF: split out to_datetime_with_unit, _to_datetime_with_format #40185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Mar 2, 2021
| @@ -517,6 +487,93 @@ def _array_strptime_with_fallback( | |||
| return _box_as_indexlike(result, utc=utc, name=name) | |||
|
|
|||
|
|
|||
| def _to_datetime_with_format( | |||
There was a problem hiding this comment.
where is this called? (now)
There was a problem hiding this comment.
this is basically cut/paste/de-dented from _convert_listlike_datetimes
There was a problem hiding this comment.
woops, did the copy/paste but forgot to actually use the new function. updated
|
doc failure looks like network; ping on green. |
|
hmm can you merge master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is that to_datetime_with_format will eventually be moved into objects_to_datetime64ns, and most of _convert_listlike_datetimes will just be a call to sequence_to_dt64ns