REF: share check_value_size #40009
Merged
REF: share check_value_size #40009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,6 +40,21 @@ | |||
| from pandas import Index | |||
|
|
|||
|
|
|||
| def check_value_size(value, mask: np.ndarray, length: int): | |||
There was a problem hiding this comment.
as this is also masking the values, a different name may be more appropriate.
or maybe return none. just do the validation here and just repeat the masking in the array functions, so it it is clear to readers what is going on.
There was a problem hiding this comment.
just do the validation here and just repeat the masking in the array functions, so it it is clear to readers what is going on.
thats not a bad idea. i think we do something similar in array_algos.putmask
simonjayhawkins
added
the
ExtensionArray
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.