refactor styler tests #39946
Merged
refactor styler tests #39946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Feb 21, 2021
| .set_tooltips_class(name="other-class", properties=[("color", "green")]) | ||
| .render() | ||
| ) | ||
| assert "#T__ .other-class {\n color: green;\n" in s |
There was a problem hiding this comment.
split to more modules, e.g. tooltips to separate, the highlite* to a separate on, and rename this to align
|
|
||
|
|
||
| @td.skip_if_no_mpl | ||
| class TestStylerMatplotlibDep: |
There was a problem hiding this comment.
move to this to test_matplotlib.py
There was a problem hiding this comment.
could not find. used existing file tests/plotting/test_style.py instead. test_misc.py also seemed a good alternative.
There was a problem hiding this comment.
these are all new modules.
There was a problem hiding this comment.
duh.. my bad, assumed you were pointing to existing file
jreback
added
Styler
# Conflicts: # pandas/tests/io/formats/style/test_style.py
jreback
requested changes
Feb 22, 2021
jreback
approved these changes
Feb 22, 2021
|
great thanks @attack68 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
splits
test_style.pytostyle/test_style.pyandstyle/test_builtins.py, with the simple classification of being related tocorefunctionality or addedextensions.