Skip to content

BENCH: collect low-dependency asvs #39917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2021

Conversation

jbrockmendel
Copy link
Member

The idea here is to collect benchmarks in such a way that we can say "This PR doesn't change code in files [...] -> We can skip running asvs in files [...]". (putting together a POC script to automate a bit of this)

There is a cost to refactoring benchmarks, since we have to re-run the new benchmarks on older commits (and im not sure if that happens automatically or if some human intervention is needed cc @TomAugspurger ?). On the flip side, this is the kind of problem that we can throw hardware at, so I don't worry about it that much. Still, the bar for merging is higher than it would be for non-benchmark refactors.

With that in mind, the other refactors I'm looking at:

  1. We have benchmarks for e.g. isin scattered around, benchmarking [algos.isin(x, y), pd.array(x).isin(y), Index(s).isin(y), Series(x).isin(y)]. I'd like to collect these in one place and parametrize them.

  2. Similar for Index methods, we have a lot of similar benchmarks for different index subclasses that id like to collect+parametrize.

@jreback jreback added the Benchmark Performance (ASV) benchmarks label Feb 21, 2021
@jreback jreback added this to the 1.3 milestone Feb 21, 2021
@jreback
Copy link
Contributor

jreback commented Feb 27, 2021

seems fine can you merge master

@jbrockmendel
Copy link
Member Author

rebased + green

@jreback jreback merged commit 8f87907 into pandas-dev:master Mar 1, 2021
@jbrockmendel jbrockmendel deleted the asv-inference branch March 1, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benchmark Performance (ASV) benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants