Skip to content

REF: remove unnecessary PeriodIndex._get_indexer #39685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 8, 2021

Conversation

jbrockmendel
Copy link
Member

No description provided.

@jreback jreback added Clean Index Related to the Index class or subclasses Period Period data type labels Feb 8, 2021
@jreback jreback added this to the 1.3 milestone Feb 8, 2021
@jreback
Copy link
Contributor

jreback commented Feb 8, 2021

hmm lots of things are failing here. maybe an ensure_indexer issue?

@jreback
Copy link
Contributor

jreback commented Feb 8, 2021

worse: https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=53846&view=logs&j=acc1347f-8235-55b0-95c7-0e2189e61659&t=486f34f1-eda6-516a-fc5d-d8195128dacd

>   value = parse_timedelta_string(value)
E   TypeError: Expected unicode, got numpy.str_

@jbrockmendel
Copy link
Member Author

hmm lots of things are failing here. maybe an ensure_indexer issue?

i think i switched the order of a np.asarray/to_timedelta call, just tried re-ordering them

@jreback jreback merged commit f7f03f3 into pandas-dev:master Feb 8, 2021
@jbrockmendel jbrockmendel deleted the ref-pi-get_indexer branch February 8, 2021 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Index Related to the Index class or subclasses Period Period data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants