-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
BUG: Series.loc raising KeyError for Iterator indexer in case of setitem #39623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
ea198b8
BUG: Series.loc raising KeyError for Iterator indexer in case of setitem
phofl 00a9b95
Move test
phofl df248cf
Regression in to_excel when setting duplicate column names
phofl 44d2041
Add support for iloc iterator indexer
phofl 989d181
Revert "Regression in to_excel when setting duplicate column names"
phofl 5099803
Merge branch 'master' of https://github.com/pandas-dev/pandas into 39614
phofl d171530
Merge branch 'master' of https://github.com/pandas-dev/pandas into 39614
phofl f20d0f6
Merge branch 'master' of https://github.com/pandas-dev/pandas into 39614
phofl 53516d4
Merge branch 'master' of https://github.com/pandas-dev/pandas into 39614
phofl 9924314
Add tests for one dimensional indexer
phofl 6ab5839
Handle iterator for all cases
phofl 955e78b
Merge branch 'master' of https://github.com/pandas-dev/pandas into 39614
phofl a208fa8
Merge branch 'master' of https://github.com/pandas-dev/pandas into 39614
phofl f39cf33
Merge branch 'master' of https://github.com/pandas-dev/pandas into 39614
phofl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these tests are good, but only cover Series. do we need analogous DataFrame tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phofl i think this was the main outstanding question. if the answer is "no" then this should be good to go (merge master just to be on the safe side)
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the long wait. I have more time on my handy in the coming weeks and months again :)
One-dimensional indexers on DataFrames work, but two dimensionals like
still don't, because we access the tuple elements to check things before doing anything, which leaves an empty generator behind. Only way I am seeing currently is converting this directly in setitem and getitem. Thoughts @jbrockmendel ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expect this is probably right
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will Put something up then tomorrow or the day after