REF: Move part of groupby.agg to apply #39311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Apply
jreback
reviewed
Jan 21, 2021
| @@ -203,6 +203,18 @@ def test_aggregate_str_func(tsframe, groupbyfunc): | |||
| tm.assert_frame_equal(result, expected) | |||
|
|
|||
|
|
|||
| def test_agg_str_with_kwarg_axis_1_raises(df, reduction_func): | |||
| gb = df.groupby(level=0) | |||
| if reduction_func in ("idxmax", "idxmin"): | |||
There was a problem hiding this comment.
With regards to idxmax/idxmin, no. Those are the two reduction_func that support axis=1 (whereas all others do not). However, they fail here because df has string and numeric columns.
|
thanks @rhshadrach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commit adjusted to account for the false positive on
Union[SeriesGroupBy, DataFrameGroupBy].Moves part of groupby.agg implementation from
pandas.core.aggregationtopandas.core.apply. The only difference in the code is that inapply, the error message raised is different when the argument is a string (e.g. "sum") and the kwarg axis=1 is provided. Added a test to check for error message.After this will be resample and rolling, then much of the implementation code in core.aggregation code can be moved into apply.