-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
ENH: Add numba engine to several rolling aggregations #38895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
db2f86d
Add engine arguments to methods that support numpy nan methods
mroeschke 8a7bbed
Route arguments through apply
mroeschke 61f6f89
Merge remote-tracking branch 'upstream/master' into enh/rolling_table…
mroeschke 10dd6aa
Add docs
mroeschke 0707c28
Merge remote-tracking branch 'upstream/master' into enh/rolling_table…
mroeschke 65607fc
Correct std and var signature. Add sem to fixture
mroeschke 2ff5fe2
realized numba does not support axis or ddof arguments in np.nan* fun…
mroeschke eaee1cc
Move median func below
mroeschke cce6181
fix commented code
mroeschke 7edd140
Remove numba engine from quantile
mroeschke 344485f
Remove other arguments from quantile
mroeschke 4ce2a78
Add numba engine tests single method test
mroeschke 353fab6
Change to assert_series_equal
mroeschke 33e0552
Add whatsnew note
mroeschke a56fe92
Add PR number
mroeschke fee8e2e
Merge remote-tracking branch 'upstream/master' into enh/rolling_table…
mroeschke 6bc1333
Remove redundant doc section
mroeschke 6bc330b
Merge remote-tracking branch 'upstream/master' into enh/rolling_table…
mroeschke 76fc33f
Merge remote-tracking branch 'upstream/master' into enh/rolling_table…
mroeschke 481bfd4
Merge remote-tracking branch 'upstream/master' into enh/rolling_table…
mroeschke 178543b
Add ASV benchmarks
mroeschke d8582dd
Add engine arg
mroeschke 49bae51
Add note in user_guide
mroeschke f0e5e59
Merge remote-tracking branch 'upstream/master' into enh/rolling_table…
mroeschke fc4656c
xfail instead of comment out
mroeschke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -52,6 +52,7 @@ Other enhancements | |
- Improved integer type mapping from pandas to SQLAlchemy when using :meth:`DataFrame.to_sql` (:issue:`35076`) | ||
- :func:`to_numeric` now supports downcasting of nullable ``ExtensionDtype`` objects (:issue:`33013`) | ||
- :func:`pandas.read_excel` can now auto detect .xlsb files (:issue:`35416`) | ||
- :meth:`.Rolling.sum`, :meth:`.Expanding.sum`, :meth:`.Rolling.mean`, :meth:`.Expanding.mean`, :meth:`.Rolling.median`, :meth:`.Expanding.median`, :meth:`.Rolling.max`, :meth:`.Expanding.max`, :meth:`.Rolling.min`, and :meth:`.Expanding.min` now support ``Numba`` execution with the ``engine`` keyword (:issue:`38895`) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. might be worth a note in the user docs as well |
||
|
||
.. --------------------------------------------------------------------------- | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these benchmarks still reasonable in terms of total time, e.g. < 1s per
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each benchmark is around ~1s. Is that too much?