Skip to content

CLN: testing window namespace #38095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 26, 2020
Merged

CLN: testing window namespace #38095

merged 2 commits into from
Nov 26, 2020

Conversation

mroeschke
Copy link
Member

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

It appears we are heading this general direction in pandas imports in tests.

@mroeschke mroeschke added Code Style Code style, linting, code_checks Window rolling, ewma, expanding labels Nov 26, 2020
@mroeschke mroeschke added this to the 1.2 milestone Nov 26, 2020
@jreback
Copy link
Contributor

jreback commented Nov 26, 2020

yep, though not yet completely enforced. merge on green.

@jreback jreback merged commit ade94e5 into pandas-dev:master Nov 26, 2020
@jreback
Copy link
Contributor

jreback commented Nov 26, 2020

thanks @mroeschke

@mroeschke mroeschke deleted the clean/testing_window_namespace branch November 27, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimcmaster1 alimcmaster1 alimcmaster1 approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks Window rolling, ewma, expanding
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@mroeschke @jreback @alimcmaster1