TST: add error message match for raise in test_datetimelike.py GH30999 #37952
Conversation
| f"or array of those. Got '{type(string).__name__}' instead." | ||
| ), | ||
| ): | ||
| arr.searchsorted(string) |
There was a problem hiding this comment.
can this (and line 325) be kept as they originally were?
There was a problem hiding this comment.
@MarcoGorelli I see the point to keep it as original here. For line325, is it because extract_array() may change later and break the test? And in contract, StringArray (type name) is less likely to change.
There was a problem hiding this comment.
It's not too important admittedly, it's just to minimise the amount of logic in tests as any assignment / substitution / branch has the potential to introduce bugs. When we write source code we want to write helper functions and not repeat ourselves and all of that, but for tests repetition is more acceptable - see https://testing.googleblog.com/2014/07/testing-on-toilet-dont-put-logic-in.html
There was a problem hiding this comment.
Got it. The article is very helpful. Thanks a lot!
| f"value should be a '{arr1d._scalar_type.__name__}', 'NaT', " | ||
| f"or array of those. Got '{type(string).__name__}' instead." |
There was a problem hiding this comment.
match takes a regular expression, which is checked using re.search. So the .s will match any character - can you use match=re.escape( instead of match=?
jreback
added
Testing
|
lgtm. @MarcoGorelli merge when ready. |
|
Thanks @liaoaoyuan97 ! |
Reference #30999
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff