Skip to content

DOC: add unqiue value counts example to groupyby guide #37847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 25, 2020

Conversation

Abo7atm
Copy link
Contributor

@Abo7atm Abo7atm commented Nov 14, 2020

Co-authored-by: Abdulelah Almesfer 28743265+abdulelahsm@users.noreply.github.com
Co-authoerd-by: Abdulellah Alnumay 33042538+Abo7atm@users.noreply.github.com

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Adding an example to the groupby user guide. The example showcases the usage of nunique aggregate function. This is from the PyData Global sprint, from this issue. The example is taken from StackOverflow.

Abo7atm and others added 3 commits November 14, 2020 22:22
Co-authored-by: Abdulelah Almesfer <28743265+abdulelahsm@users.noreply.github.com>
Co-authoerd-by: Abdulellah Alnumay <33042538+Abo7atm@users.noreply.github.com>
Co-authored-by: Abdulelah Almesfer <28743265+abdulelahsm@users.noreply.github.com>
Co-authoerd-by: Abdulellah Alnumay <33042538+Abo7atm@users.noreply.github.com>
Co-authored-by: Abdulelah Almesfer <28743265+abdulelahsm@users.noreply.github.com>
Co-authoerd-by: Abdulellah Alnumay <33042538+Abo7atm@users.noreply.github.com>
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Abo7atm

For context, this is a common duplicate on StackOverflow, so I think it's good to include it in the docs.

Did you try building this page of the docs locally? If so, can you post a screenshot of this new section?

Abo7atm and others added 2 commits November 15, 2020 18:39
Co-authored-by: Marco Gorelli <m.e.gorelli@gmail.com>
Co-authored-by: Marco Gorelli <m.e.gorelli@gmail.com>
@Abo7atm
Copy link
Contributor Author

Abo7atm commented Nov 15, 2020

Screen Shot 2020-11-15 at 18 40 51

@jreback jreback added this to the 1.2 milestone Nov 18, 2020
@Abo7atm
Copy link
Contributor Author

Abo7atm commented Nov 18, 2020

@jreback done 👍

@jreback
Copy link
Contributor

jreback commented Nov 24, 2020

can you merge master @Abo7atm the precommit checks are failing

@Abo7atm
Copy link
Contributor Author

Abo7atm commented Nov 24, 2020

@jreback merged master and ran precommit locally with pre-commit run --files doc/source/user_guide/groupby.rst and everything passed.

@jreback jreback merged commit 61f67b6 into pandas-dev:master Nov 25, 2020
@jreback
Copy link
Contributor

jreback commented Nov 25, 2020

thanks @Abo7atm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants