Skip to content

TST/REF: collect tests from test_api into method-specific files #37525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 31, 2020
Merged

TST/REF: collect tests from test_api into method-specific files #37525

merged 8 commits into from
Oct 31, 2020

Conversation

jbrockmendel
Copy link
Member

I was surprised we didnt already have a test_copy

Also an easter egg:

    def test_keys(self, datetime_series):	    
        # HACK: By doing this in two stages, we avoid 2to3 wrapping the call
        # to .keys() in a list()	
        getkeys = datetime_series.keys	
        assert getkeys() is datetime_series.index

jreback
jreback requested changes Oct 31, 2020
View reviewed changes
pandas/tests/frame/methods/test_to_numpy.py
@@ -0,0 +1,32 @@
import numpy as np
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't these be with test_values.py

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these tests are for to_numpy. yes the methods are related, but this is the best way to keep the "where are tests for X" unambiguous

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@jreback jreback added this to the 1.2 milestone Oct 31, 2020
@jreback jreback added the Testing pandas testing functions or related to the test suite label Oct 31, 2020
@jreback jreback merged commit 2b93155 into pandas-dev:master Oct 31, 2020
@jbrockmendel jbrockmendel deleted the tst-api-2 branch October 31, 2020 16:03
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@jbrockmendel
TST/REF: collect tests from test_api into method-specific files (pand…
a234b97 
…as-dev#37525)
ukarroum pushed a commit to ukarroum/pandas that referenced this pull request Nov 2, 2020
@jbrockmendel @ukarroum
TST/REF: collect tests from test_api into method-specific files (pand…
35a92c7 
…as-dev#37525)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback