BUG: Series[uintarray] failing to raise KeyError #37495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
changed the title
jreback
added
Bug
Dtype Conversions
jreback
requested changes
Oct 30, 2020
| @@ -147,6 +147,17 @@ def test_getitem_intlist_multiindex_numeric_level(self, dtype, box): | |||
| with pytest.raises(KeyError, match="5"): | |||
| ser[key] | |||
|
|
|||
| @pytest.mark.parametrize("dtype", [np.uint8, np.uint16, np.uint32, np.uint64]) | |||
There was a problem hiding this comment.
can you create a fixture that is all numpy + all ea int dtypes (maybe call it INT_INDEXING or something) and use it here
There was a problem hiding this comment.
looks like there is a fixture uint_dtype that makes sense to use here, will update
jreback
approved these changes
Oct 30, 2020
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
* CI: 32 bit maybe_indices_to_slice * accept either * revert * troubleshoot * try again * intp * multiindex np.intp * revert branched from wrong branch * BUG: Series[uint8array] failing to raise KeyError * use fixture
ukarroum
pushed a commit
to ukarroum/pandas
that referenced
this pull request
Nov 2, 2020
* CI: 32 bit maybe_indices_to_slice * accept either * revert * troubleshoot * try again * intp * multiindex np.intp * revert branched from wrong branch * BUG: Series[uint8array] failing to raise KeyError * use fixture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff