CLN: de-duplicate validator #37458
Merged
CLN: de-duplicate validator #37458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanovmg
reviewed
Oct 28, 2020
| f"value should be a '{self._scalar_type.__name__}', 'NaT', " | ||
| f"or array of those. Got '{type(value).__name__}' instead." | ||
| ) | ||
| msg = self._validation_error_message(value, True) |
There was a problem hiding this comment.
Nice de-duplication.
I suggest using the named argument allow_listlike=True for clarity.
Otherwise, looks good to me.
There was a problem hiding this comment.
@jbrockmendel yeah might be more clear (but ok to do in next cleanup PR)
jreback
added
Admin
…n-dtvalidators-3
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
ukarroum
pushed a commit
to ukarroum/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff