Skip to content

REF/TYP: arrays.datetimelike #36932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 10, 2020
Merged

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@simonjayhawkins this is still giving me two mypy complaints locally:

pandas/core/arrays/datetimelike.py:549: error: Too many arguments for "object"  [call-arg]
pandas/core/arrays/datetimelike.py:556: error: Too many arguments for "object"  [call-arg]

These lines are both calls to self._scalar_type(foo)

_scalar_type is annotated as Type[DatetimeLikeScalar], which is a TypeVar for Period/Timestamp/Timedelta. Is there a non-ignoring solution here?

@jreback jreback added the Typing type annotations, mypy/pyright type checking label Oct 8, 2020
@jreback jreback added this to the 1.2 milestone Oct 8, 2020
@jbrockmendel
Copy link
Member Author

updated to revert the setup.cfg edit for now to get CI passing

@jreback
Copy link
Contributor

jreback commented Oct 10, 2020

one more rebase to make sure didn't break anything from a recent merge (as I saw some PRs using DatetimeArraylikeMixin) but could be mistaken.

@jbrockmendel
Copy link
Member Author

are both travis and azure down?

@jreback jreback merged commit e2788da into pandas-dev:master Oct 10, 2020
@jreback
Copy link
Contributor

jreback commented Oct 10, 2020

thanks. ideally if we can see what has changed about the failing builds. maybe a package was released which bumped things?

@jbrockmendel jbrockmendel deleted the ref-dtlike-typ branch October 10, 2020 22:45
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
* TYP: refactor datetimelike.py to satisfy typing

* test fixup

* revert setup.cfg edit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants