REF/TYP: arrays.datetimelike #36932
Merged
REF/TYP: arrays.datetimelike #36932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
updated to revert the setup.cfg edit for now to get CI passing |
|
one more rebase to make sure didn't break anything from a recent merge (as I saw some PRs using DatetimeArraylikeMixin) but could be mistaken. |
|
are both travis and azure down? |
|
thanks. ideally if we can see what has changed about the failing builds. maybe a package was released which bumped things? |
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
* TYP: refactor datetimelike.py to satisfy typing * test fixup * revert setup.cfg edit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff@simonjayhawkins this is still giving me two mypy complaints locally:
These lines are both calls to
self._scalar_type(foo)_scalar_type is annotated as
Type[DatetimeLikeScalar], which is a TypeVar for Period/Timestamp/Timedelta. Is there a non-ignoring solution here?