Skip to content

REF: IntervalIndex.equals defer to IntervalArray.equals #36871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Small behavior change in that interval_index.equals(series[interval]) will now return False, matching other Index subclasses.

@@ -115,6 +117,13 @@ def T(self: _T) -> _T:

# ------------------------------------------------------------------------

def equals(self, other) -> bool:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is hitting this one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now the implementation used by PandasArray.equals

@jreback jreback added the Interval Interval data type label Oct 5, 2020
@jreback jreback added this to the 1.2 milestone Oct 6, 2020
@jreback jreback added the Refactor Internal refactoring of code label Oct 6, 2020
@jreback jreback merged commit c5637a8 into pandas-dev:master Oct 6, 2020
@jbrockmendel jbrockmendel deleted the ref-ei-equals branch October 6, 2020 23:10
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Interval Interval data type Refactor Internal refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants