TST: Verify parsing of data with encoded special characters (16218) #36841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Oct 4, 2020
pandas/tests/io/test_common.py
Outdated
| @pytest.mark.parametrize( | ||
| "encoding", ["utf-8", "utf-16", "utf-16-be", "utf-16-le", "utf-32"] | ||
| ) | ||
| def test_parse_encoded_special_characters(encoding): |
There was a problem hiding this comment.
Could you move this to pandas/tests/io/parser/test_encoding.py?
mroeschke
approved these changes
Oct 4, 2020
|
@mroeschke do I need to merge master or is the PR good like this? |
|
@avinashpancham could you merge master one more time? Sorry, that this has been ignored. Hopefully our flakey CI issues have been solved |
|
Np @mroeschke, merged master and everything passes now. |
mroeschke
approved these changes
Oct 12, 2020
|
Thanks @avinashpancham |
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Oct 26, 2020
…andas-dev#36841) * TST: Verify parsing of data with encoded special characters * Move
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
…andas-dev#36841) * TST: Verify parsing of data with encoded special characters * Move
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff