Skip to content

DOC: Fix PR09 errors in several files #36763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 2, 2020
Merged

DOC: Fix PR09 errors in several files #36763

merged 4 commits into from
Oct 2, 2020

Conversation

Iqrar99
Copy link
Contributor

@Iqrar99 Iqrar99 commented Oct 1, 2020

  • closes DOC: PR09 errors #36764
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

As far as I can see, there are some PR09 pandas docstring errors. So with this PR I will resolve them. There are more commits soon.

PR09
Parameter description should finish with "."

@Iqrar99 Iqrar99 marked this pull request as ready for review October 1, 2020 07:06
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Iqrar99 minor comment otherwise lgtm.

@simonjayhawkins simonjayhawkins added this to the 1.2 milestone Oct 2, 2020
@simonjayhawkins simonjayhawkins merged commit 4de9b5b into pandas-dev:master Oct 2, 2020
@simonjayhawkins
Copy link
Member

Thanks @Iqrar99

@Iqrar99
Copy link
Contributor Author

Iqrar99 commented Oct 3, 2020

You are welcome! Happy to help.

@Iqrar99 Iqrar99 deleted the pr09 branch October 3, 2020 01:43
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: PR09 errors
2 participants