Skip to content

TST: honor encoding in read_fwf for memory-mapped files #36737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2020
Merged

TST: honor encoding in read_fwf for memory-mapped files #36737

merged 1 commit into from
Sep 30, 2020

Conversation

twoertwein
Copy link
Member

encoding was already working for memory-mapped files in read_fwf.

@jreback jreback added this to the 1.2 milestone Sep 30, 2020
@jreback jreback added IO CSV read_csv, to_csv IO Fixed Width read_fwf Testing pandas testing functions or related to the test suite labels Sep 30, 2020
@pep8speaks
Copy link

Hello @twoertwein! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 640:1: W293 blank line contains whitespace

@jreback
Copy link
Contributor

jreback commented Sep 30, 2020

@twoertwein rebased this in the browser and i think introduced an issue, can you rebase and ping on green. thanks!

WillAyd
WillAyd approved these changes Sep 30, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (when green)

@jreback jreback merged commit a2761f5 into pandas-dev:master Sep 30, 2020
@jreback
Copy link
Contributor

jreback commented Sep 30, 2020

thanks @twoertwein

@twoertwein twoertwein deleted the fwf_encoding branch September 30, 2020 17:25
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@twoertwein
TST: honor encoding in read_fwf for memory-mapped files (pandas-dev#3…
b73ede4 
…6737)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
IO CSV read_csv, to_csv IO Fixed Width read_fwf Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

read_fwf: encoding is ignored when memory_map is True
4 participants
@twoertwein @pep8speaks @jreback @WillAyd