REF: rearrange test_to_latex.py #36714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
IO LaTeX
|
can you just confirm that before & after test counts are the same for latex. |
|
"Added" tests: "Deleted" tests: One extra test was added: |
ivanovmg
commented
Sep 30, 2020
Comment on lines
-155
to
108
| def test_to_latex_column_format(self, float_frame): | ||
| def test_to_latex_column_format_just_works(self, float_frame): | ||
| # GH Bug #9402 | ||
| float_frame.to_latex(column_format="lcr") | ||
|
|
||
| def test_to_latex_column_format(self): | ||
| df = DataFrame({"a": [1, 2], "b": ["b1", "b2"]}) |
There was a problem hiding this comment.
This is where I extracted tests _just_works.
|
thanks @ivanovmg |
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffRearranged tests in
test_to_latex.pyto the corresponding classes.Sorry for the messy diffs.
All I did (except to small commits cd92db9 and 2b66e2f) was rearrangement of the tests.