TST: add html5lib to travis

[cpcloud]

closes #3654

[cpcloud]

darn :| tox gave me false hope

[jreback]

any luck?

[cpcloud]

nah i'm not sure what the problem is, haven't had a chance to get into it yet...2.7 fails (slightly weird since that's what i'm running), and all tox versions pass on my machine. my gut tells me that there some simple thing going wrong here, but i need to investigate. i had this problem locally once when bs4 was installed both from the launchpad source and from the pypi mirrors, but I don't see where this could've happened on travis.

[jreback]

I have a vagrant 32-bit environ setup....just tested and it fails like travis (which is 32-bit btw)...

[cpcloud]

oh gosh. thanks. i have a similar machine at home i will be able to test it like this later...

[jreback]

First failure

115         def test_banklist(self):
116             df1 = self.run_read_html(self.banklist_data, '.*Florida.*',
117  ->                                  attrs={'id': 'table'})

387         def _parse_tables(self, doc, match, attrs):
388             element_name = self._strainer.name
389             tables = doc.find_all(element_name, attrs=attrs)
390             if not tables:
391  ->             raise AssertionError('No tables found')

[jreback]

maybe bs4 has a weird thing on 32-bit

[jreback]

you can setup www.vagrantup.com. ....any type of machine you want (for ssh)...btw...free....

I setup a 32-bit because I can't easily test that otherwise

[cpcloud]

oh that is sweet. thanks.

[cpcloud]

still though if bs4 has a weird 32-bit thing then why are 2.6 and 3.2 passing? so strange

[cpcloud]

sorry 3.3

[jreback]

yes...that is weird....prob is something really simple

[cpcloud]

i've setup vagrant so i can get to this a little later or this evening

[cpcloud]

okay i can reproduce this...it's a start

[cpcloud]

progress: it works with the ubuntu repo install sounds like a venv prob ugh

[cpcloud]

@jreback not sure what to do here. worth figuring out this bug? don't think it's pandas related

[cpcloud]

soln is to install read_html deps using apt

[jreback]

oh...that looks fine.....
can you squash to one?

[jreback]

so looks like will test with full_deps on 2.7, but not 3.2?

its fine, only think I would maybe be concerned about is unicode issues....e.g.

a 3.3/3.2 person parses a table which is treated as unicode (though you can 'simulate') this as well

[cpcloud]

no sorry i fixed so installed on all versions that's what all those commits were for before :)

[cpcloud]

crap unless they need a "python3" prefix...grumbles

[cpcloud]

(2.6 and 3.3 passed because the tests were ignored due to lack of deps)

[cpcloud]

i think this is a bs4 bug, will report. older version of bs4 included in apt works fine whereas pip version doesn't work. this still holds no matter which version of html5lib or lxml i use.

[cpcloud]

@jreback oh joy this worked!

[cpcloud]

should i note this in the docs? something like "if you're on a 32-bit machine use version X of bs4"

[jreback]

so if I understand

32-bit, use apt-get
64-bit, use pip (OR apt-get)?

yes, just put it in the doc string / docs / install.rst (but be as brief as possibly)....

[cpcloud]

one slight issue there that might matter: if u want (need) to use the apt-get bs4 then you cannot use lxml that comes with it (if u want to use lxml) you must use the pip version. this is so annoying...

[cpcloud]

travis fails bs4 + lxml tests when u use the apt-get version of lxml

[cpcloud]

i'm ready to just write my own f---ing html table parser in cython...

[jreback]

just put a big warning/note in the docs

[cpcloud]

i just remem'd that doesn't matter ATM since we're disallowing lxml anyway...(the lxml install issue doesn't matter atm the other issue does)

[jreback]

true....but apparently io.data uses lxml for some parsing (but if that's an issue then the user can deal with it)....
just put in a note

[cpcloud]

oh yeah i forgot about that, some stuff with yahoo stocks i think...almost finished

[jreback]

looks great...ready to merge?

[cpcloud]

Yep
On May 21, 2013 9:20 AM, "jreback" notifications@github.com wrote:

looks great...ready to merge?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/3655#issuecomment-18207940
.

[jreback]

ok.cross fingers

[jreback]

all green on master!

[cpcloud]

Nice!
On May 21, 2013 10:07 AM, "jreback" notifications@github.com wrote:

all green on master!

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/3655#issuecomment-18210802
.

[cpcloud]

Thanks for your help!
On May 21, 2013 10:07 AM, "jreback" notifications@github.com wrote:

all green on master!

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/3655#issuecomment-18210802
.