BUG: incorrect year returned in isocalendar for certain dates #36050
Conversation
asishm
changed the title
|
I'm not sure if a new test is needed here. I added the failing case to parametrize. |
| @@ -682,6 +682,7 @@ def test_setitem_with_different_tz(self): | |||
| [[pd.NaT], [[np.NaN, np.NaN, np.NaN]]], | |||
| [["2019-12-31", "2019-12-29"], [[2020, 1, 2], [2019, 52, 7]]], | |||
| [["2010-01-01", pd.NaT], [[2009, 53, 5], [np.NaN, np.NaN, np.NaN]]], | |||
| [["2016-01-08"], [[2016, 1, 5]]], # see GH#36032 | |||
There was a problem hiding this comment.
can you add some of the working cases from the original issue (that work)
There was a problem hiding this comment.
done
also tested with this locally
import pandas as pd
dates = pd.date_range('1677-09-22', '2262-04-10', freq='D')
pd_iso = dates.isocalendar()
py_dates_iso = [date.isocalendar() for date in dates.to_pydatetime()]
py_iso = pd.DataFrame(py_dates_iso, columns=['year', 'week', 'day'], index=dates, dtype='UInt32')
assert pd_iso.equals(py_iso)
| @@ -682,6 +682,9 @@ def test_setitem_with_different_tz(self): | |||
| [[pd.NaT], [[np.NaN, np.NaN, np.NaN]]], | |||
| [["2019-12-31", "2019-12-29"], [[2020, 1, 2], [2019, 52, 7]]], | |||
| [["2010-01-01", pd.NaT], [[2009, 53, 5], [np.NaN, np.NaN, np.NaN]]], | |||
| # see GH#36032 | |||
| [["2016-01-08", "2016-01-04"], [[2016, 1, 5], [2016, 1, 1]]], | |||
| [["2016-01-07", "2016-01-01"], [[2016, 1, 4], [2015, 53, 5]]], | |||
There was a problem hiding this comment.
is there another implementation somewhere (maybe stdlib calendar) we can use to compare against?
There was a problem hiding this comment.
i guess datetime.isocalendar would make sense
There was a problem hiding this comment.
There was a problem hiding this comment.
@jbrockmendel I didn't want to change the current implementation too much, but I tested with datetime.isocalendar locally.
There was a problem hiding this comment.
Can you add in tests.tslibs.test_ccalendar (OK for follow-up):
from hypothesis import given, strategies as st
@given(st.datetimes(min_value=pd.Timestamp.min.to_pydatetime(), max_value=pd.Timestamp.max.to_pydatetime())
def test_isocalendar(dt):
expected = dt.isocalendar()
result = ccalendar.get_iso_calendar(dt.year, dt.month, dt.day)
assert result == expected
There was a problem hiding this comment.
@jbrockmendel Unsure how to resolve the CI failures. should I just add warn=False in the to_pydatetime call?
https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=41452&view=ms.vss-test-web.build-test-results-tab&runId=2135520&resultId=100016&paneView=debug
|
LGTM |
|
thanks @asishm |
…ndar for certain dates
…ertain dates (#36127) Co-authored-by: Asish Mahapatra <asishkm@gmail.com>
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff