Skip to content

TYP: add type annotation to _xlwt.py #36024 #36025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 1, 2020
Merged

TYP: add type annotation to _xlwt.py #36024 #36025

merged 2 commits into from
Sep 1, 2020

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Sep 1, 2020 •
edited by simonjayhawkins
Loading

pandas\io\excel_xlwt.py:52: error: Need type annotation for 'style_dict' (hint: "style_dict: Dict[, ] = ...") [var-annotated]

@fangchenli fangchenli changed the title TYP: add type annotation #36024 TYP: add type annotation to _xlwt.py #36024 Sep 1, 2020
@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Sep 1, 2020
simonjayhawkins
simonjayhawkins requested changes Sep 1, 2020
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @VirosaLi for the PR.

If you can add the mypy errors that the PR is addressing in the OP, generally helps reviewers. (Also don't need to open issues for these)

@simonjayhawkins simonjayhawkins added this to the 1.2 milestone Sep 1, 2020
simonjayhawkins
simonjayhawkins approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @VirosaLi lgtm

@WillAyd WillAyd merged commit e6ebb5c into pandas-dev:master Sep 1, 2020
@WillAyd
Copy link
Member

WillAyd commented Sep 1, 2020

Thanks @VirosaLi

@fangchenli fangchenli deleted the type-xlwt branch September 2, 2020 01:06
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@fangchenli
TYP: add type annotation to _xlwt.py pandas-dev#36024 (pandas-dev#3…
c010752 
…6025)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

TYP: add type annotation to _xlwt.py
3 participants
@fangchenli @WillAyd @simonjayhawkins